Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch initial server version async #1239

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Fetch initial server version async #1239

merged 2 commits into from
Apr 7, 2022

Conversation

axw
Copy link
Member

@axw axw commented Apr 7, 2022

Fixes #1238

@axw axw force-pushed the newtracer-nonblocking branch from e64fa7b to 9ed7b16 Compare April 7, 2022 07:28
@axw axw marked this pull request as ready for review April 7, 2022 07:29
@axw axw requested a review from a team April 7, 2022 07:29
marclop
marclop approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@apmmachine
Copy link
Contributor

apmmachine commented Apr 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-07T12:00:30.011+0000

  • Duration: 51 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 8337
Skipped 201
Total 8538

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw enabled auto-merge (squash) April 7, 2022 07:50
@axw axw merged commit b69a267 into elastic:main Apr 7, 2022
@axw axw deleted the newtracer-nonblocking branch April 7, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclop marclop marclop approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewTracer(Options) blocks up to 10 seconds when server is unresponsive
3 participants
@axw @apmmachine @marclop