Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize *auth* instead of authorization #1230

Merged
merged 4 commits into from
Mar 23, 2022
Merged

sanitize *auth* instead of authorization #1230

merged 4 commits into from
Mar 23, 2022

Conversation

stuartnelson3
Copy link
Contributor

closes #1166

@stuartnelson3 stuartnelson3 requested a review from a team March 23, 2022 09:38
axw
axw approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartnelson3
Copy link
Contributor Author

Failure is due to http2 :authority pseudo-header, which should be excluded: elastic/apm#575

@apmmachine
Copy link
Contributor

apmmachine commented Mar 23, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-23T09:57:35.120+0000

  • Duration: 49 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 8328
Skipped 201
Total 8529

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@stuartnelson3 stuartnelson3 enabled auto-merge (squash) March 23, 2022 09:58
@stuartnelson3 stuartnelson3 merged commit 27eb50e into elastic:main Mar 23, 2022
@stuartnelson3 stuartnelson3 deleted the sanitize-auth-field branch March 23, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 576] Sanitize *auth* instead of authorization
3 participants
@stuartnelson3 @apmmachine @axw