Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Sampler with ExtendedSampler #1206

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Conversation

axw
Copy link
Member

@axw axw commented Feb 3, 2022

Since we're making breaking changes, replace the Sampler interface with ExtendedSampler.

@axw axw requested a review from a team February 3, 2022 05:28
@apmmachine
Copy link
Contributor

apmmachine commented Feb 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T05:28:50.203+0000

  • Duration: 51 min 17 sec

  • Commit: ed05fc4

Test stats 🧪

Test Results
Failed 0
Passed 7206
Skipped 174
Total 7380

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw merged commit cdc4eb4 into elastic:main Feb 3, 2022
@axw axw deleted the extendedsampler-begone branch February 3, 2022 08:27
@simitt simitt added this to the 2.0 milestone Feb 9, 2022
@simitt
Copy link
Contributor

simitt commented Feb 9, 2022

I don't believe we expect this interface to be used externally, so I labeled with test-plan-skip; let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants