-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transport.Default #1195
Remove transport.Default #1195
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
CHANGELOG.asciidoc
Outdated
- Remove stacktrace.ContextSetter {pull}1187[#(1187)] | ||
- Drop support for versions of Go prior to 1.15.0 {pull}1190[#(1190)] | ||
- Replace apm.DefaultTracer with an initialization function {pull}1189[#(1189)] | ||
- Remove transport.Default, construct a new Transport in each new tracer {pull}[#()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the missing notes to the change log, I've been meaning to do so, but hadn't gotten to it.
I verified that package main
import (
"go.elastic.co/apm/v2/transport"
)
func main() {
transport.Default
} $ go run a/main.go
# command-line-arguments
a/main.go:25:2: undefined: transport.Default |
Remove
transport.Default
, and construct a new transport for each new tracer. This will enable us to pass the tracer's associated service name and version into its transport, for appending to the User-Agent header.Closes #1194