-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer destination service resource adapt public api #1003
Merged
stuartnelson3
merged 20 commits into
elastic:master
from
stuartnelson3:infer-destination-service-resource-adapt-public-api
Aug 16, 2021
Merged
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9965339
deprecate destination.service.{name,type}
stuartnelson3 1e5a0f1
Add support for exit spans
stuartnelson3 bd6aa81
shorten for-range syntax
stuartnelson3 a987f9d
extra duplicate logic to fn
stuartnelson3 440e222
add Name back to destination service span
stuartnelson3 ec067cb
revert changes to test
stuartnelson3 e402a2a
move `exit` to span
stuartnelson3 723ba65
remove comment
stuartnelson3 738a944
Set exit span via SpanOptions
stuartnelson3 971620c
Remove `omitempty`
stuartnelson3 2bf571f
"finer grained" locking
stuartnelson3 b577a55
[aws] re-add name to session span
stuartnelson3 a5af5c6
Set span.exit=true when ending span
stuartnelson3 ee216c4
re-add Name
stuartnelson3 5c2ea80
remove inferring exit span status
stuartnelson3 a47d769
fix spancontext test
stuartnelson3 0acc139
Merge branch 'master' into infer-destination-service-resource-adapt-p…
stuartnelson3 3e62635
assign destination service resource if not set
stuartnelson3 71d1d0e
Merge branch 'master' into infer-destination-service-resource-adapt-p…
stuartnelson3 ee8cb43
/s/setExitSpan/setExitSpanDestinationService/
stuartnelson3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the spec, I believe the resource is meant to be set to
subtype || type
.Subtype and Type can be set after starting a span, so I think we need to do that when ending the span. What we can do is keep track of whether SpanContext.SetDestinationService has been called (even with empty strings), and if it is never called for an exit span, then do this implicit call when ending the exit span.