Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update elasticsearch-xpack.yml #676

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Update elasticsearch-xpack.yml #676

merged 3 commits into from
Mar 4, 2020

Conversation

nduytg
Copy link
Contributor

@nduytg nduytg commented Mar 4, 2020

Refactor file module and fix file mode syntax to support octal number format

Refactor file module and fix file mode syntax to support octal number format
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 4, 2020

💚 CLA has been signed

@jmlrt
Copy link
Member

jmlrt commented Mar 4, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Mar 4, 2020

Hi @nduytg,
Thanks for your PR.
Can you sign the CLA: https://www.elastic.co/contributor-agreement

@nduytg
Copy link
Contributor Author

nduytg commented Mar 4, 2020

Hi @jmlrt, yes I have signed it. Do I have to do anything else?

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaml require that you quotes variables starting by {{(see Ansible doc).

nduytg and others added 2 commits March 4, 2020 22:00
Copy link
Contributor Author

@nduytg nduytg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks master, i forgot to quote them :D

@jmlrt
Copy link
Member

jmlrt commented Mar 4, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Mar 4, 2020

tks master, i forgot to quote them :D

I often forget these quotes also, hopefully our CI tests are a good reminder :D

@jmlrt jmlrt merged commit 3f87694 into elastic:master Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants