Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Allow user to specify the http schema. #635

Closed
wants to merge 2 commits into from
Closed

Allow user to specify the http schema. #635

wants to merge 2 commits into from

Conversation

xocasdashdash
Copy link

This is a really simple fix that would allow us to use this module with a https elastic search. There is a PR #620 that would also allow for this to be done but this is a much smaller fix that can hopefully be merged faster.

To avoid issues with that PR once this one is merged (or discarded) I've used the same variables as those defined by #620

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
cb4c71d, 35622ad

Please, read and sign the above mentioned agreement if you want to contribute to this project

@jmlrt
Copy link
Member

jmlrt commented Nov 19, 2019

Hi @xocasdashdash, thanks for your work on this PR.
Also I like incremental improvements when possible, #620 has already been approved and will be merged this week so I'm not sure we'll need this one in addition.

@xocasdashdash
Copy link
Author

@jmlrt That's fantastic! Once it's merged, will a release be done soon? Right now I'm using my fork but once the PR is merged I can go back to using this

@jmlrt
Copy link
Member

jmlrt commented Nov 19, 2019

Once it's merged, will a release be done soon?

Yep next release including TLS should be really soon :)

@jmlrt jmlrt mentioned this pull request Nov 19, 2019
@xocasdashdash
Copy link
Author

Cool thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants