Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add option for disable the addition of official repository #582

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Add option for disable the addition of official repository #582

merged 2 commits into from
Jul 12, 2019

Conversation

ktibi
Copy link
Contributor

@ktibi ktibi commented Jun 24, 2019

Sometimes, instances can't be access to public repository on internet. We must be able to use a private repository already deployed on instance.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ktibi ktibi closed this Jun 24, 2019
@ktibi ktibi reopened this Jun 24, 2019
@ghost
Copy link

ghost commented Jun 24, 2019

Hi @ktibi, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@ghost
Copy link

ghost commented Jun 24, 2019

Hi @ktibi, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@ktibi ktibi force-pushed the option_add_repo branch 4 times, most recently from ab6bc3c to a45ecd9 Compare June 24, 2019 10:03
@ktibi
Copy link
Contributor Author

ktibi commented Jun 24, 2019

please jenkins test this

@ktibi
Copy link
Contributor Author

ktibi commented Jul 2, 2019

Hi @jmlrt !

Can you run CI ?

@jmlrt
Copy link
Member

jmlrt commented Jul 2, 2019

please jenkins test this

@jmlrt jmlrt self-assigned this Jul 2, 2019
@jmlrt jmlrt self-requested a review July 2, 2019 11:35
@jmlrt jmlrt removed their assignment Jul 2, 2019
@jmlrt
Copy link
Member

jmlrt commented Jul 2, 2019 •
edited
Loading

Hi @ktibi,

Thank you for this PR, currently the official repo is only added when es_use_repository variable is set to true (https://github.com/elastic/ansible-elasticsearch/pull/582/files#diff-693306dd337595f8eb5ef9f547093ee5R34)

Do you have some use case where you want to install elasticsearch using official repo without adding it (this one shouldn't work) or add official repo without installing elasticsearch from it?

@ktibi
Copy link
Contributor Author

ktibi commented Jul 2, 2019

Hi,

We use official repo but it is sync in our private repository (redhat satellite). The repo is deployed by an agent.

jmlrt
jmlrt suggested changes Jul 3, 2019
View reviewed changes
README.md Outdated
@@ -387,6 +387,7 @@ In addition to es_config, the following parameters allow the customization of th
* ```es_max_threads``` the maximum number of threads the process can start. Defaults to 2048 (the minimum required by elasticsearch).
* ```es_debian_startup_timeout``` how long Debian-family SysV init scripts wait for the service to start, in seconds. Defaults to 10 seconds.
* ```es_use_repository``` Setting this to `false` will stop Ansible from using the official Elastic package repositories.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es_use_repository description is now false as it can be used to install elasticsearch package from any repository configured on the system (not only official Elastic repository).

Can you fix the description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for you ?

@ktibi ktibi force-pushed the option_add_repo branch from a45ecd9 to 812faf9 Compare July 3, 2019 15:25
@jmlrt
Copy link
Member

jmlrt commented Jul 10, 2019

please jenkins test this

@jmlrt
Copy link
Member

jmlrt commented Jul 12, 2019

please jenkins test this

@jmlrt jmlrt self-requested a review July 12, 2019 08:01
jmlrt
jmlrt approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmlrt jmlrt merged commit 9df5f7f into elastic:master Jul 12, 2019
@ktibi
Copy link
Contributor Author

ktibi commented Jul 12, 2019

Thx guys ;)

@jmlrt jmlrt mentioned this pull request Jul 12, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmlrt jmlrt jmlrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktibi @elasticmachine @jmlrt