Allow switching between oss and standard packages

[Crazybus]

Before only going from the standard package to oss was supported. Now
this works properly in both directions.

Fixes: #520

[fedelemantuano]

Hi @Crazybus,

if you switch from oss to xpack or vice versa, you will have two two yum repo in system.
To have a clean config it's better remove the old one.
I know that change only the name, maybe you could use a unique name for repos oss and xpack.

[Crazybus]

@fedelemantuano Great catch! I have updated the PR so that it will remove the unused repo.

[fedelemantuano]

Hi @Crazybus, I read the new commit but I don't understand these lines.

[Crazybus]

Hi @Crazybus, I read the new commit but I don't understand these lines.

@fedelemantuano Good because it was wrong :P. I have fixed it up to remove the file instead of adding it (again). I also added some tests to make sure this is actually working properly. After adding the tests I found out that the Debian version was also only removing the package and not the repo so I have fixed that up too!

[fedelemantuano]

Yes I saw the Debian part, so I'm fixing my ansible-kibana role too.

[itsmed]

LGTM!