This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
add idempotence in check mode for plugins #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
lazouz
force-pushed
the
idempotent-check-mode
branch
from
bfca7fc to
d338849
Compare
|
Hello, Can I have a review ? ping @Crazybus cheers. |
|
jenkins test this please |
|
thanks @Crazybus :) |
|
@lazouz thanks for the fix! Honestly I'm surprised that check mode works at all! It has always been so hit and miss for me in the past (referring to other ansible work). |
This was referenced Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this line :
check_mode: no
ensures that the variable installed_plugins is defined, and the next task can be run in check mode ('undefined variable' instead)