Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

elasticsearch.yml: xpack settings added only if es_enable_xpack #427

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

cyrilleverrier
Copy link
Contributor

the default values are:

  • es_enable_xpack: false
  • es_xpack_features: ["alerting","monitoring","graph","ml","security"]

With the default values, XPACK is not installed
But the generated elasticsearch.yml contains the XPACK Settings.
Elasticsearch application refuses to start with these unknown settings

the default values are:
 - es_enable_xpack: false
 - es_xpack_features: ["alerting","monitoring","graph","ml","security"]

With the default values, XPACK is not installed
But the generated elasticsearch.yml contains the XPACK Settings.
Elasticsearch application refuses to start with these unknown settings
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

@cyrilleverrier Nice catch! Thanks for the quick fix! 👍

There were a couple of build failures when downloading elasticsearch artifacts however there was a release yesterday so I think that might explain the minor hiccups.

@Crazybus Crazybus merged commit 644a209 into elastic:master Feb 21, 2018
@cyrilleverrier
Copy link
Contributor Author

@Crazybus: Thank you for merging my PR

@cyrilleverrier cyrilleverrier deleted the fix_elasticsearch_yml_j2 branch February 21, 2018 15:10
@cyrilleverrier cyrilleverrier restored the fix_elasticsearch_yml_j2 branch February 21, 2018 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants