Change mount_series endpoint to accept and move existing series
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2024
owi92
force-pushed
the
mount-and-move-series
branch
from
a123e17 to
6a2d43e
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
fe39123 to
a9556b3
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
a9556b3 to
156f1ab
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
156f1ab to
dfc0d4d
Compare
LukasKalbertodt
requested changes
Aug 13, 2024
owi92
force-pushed
the
mount-and-move-series
branch
2 times, most recently
from
6a2d43e to
fb675ac
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
0f37033 to
fb675ac
Compare
LukasKalbertodt
force-pushed
the
master
branch
from
6fa85fe to
bc1902d
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
fb675ac to
3a5d83a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
owi92
force-pushed
the
mount-and-move-series
branch
from
3a5d83a to
a06ba4e
Compare
github-actions
bot
removed
the
status:conflicts
owi92
force-pushed
the
mount-and-move-series
branch
from
a06ba4e to
5be04f0
Compare
This comment has been minimized.
This comment has been minimized.
owi92
force-pushed
the
mount-and-move-series
branch
from
5be04f0 to
adc795b
Compare
LukasKalbertodt
requested changes
Sep 2, 2024
There was a problem hiding this comment.
We just discussed this in chat, I'm just writing it down here for protocol.
I was still not too happy with very overloaded move API. So the idea now to wait for #1179 and then add three more API endpoints to end up with these:
createRealmLineage(realms: { name: string, pathSegment: string })prefigureSeries(series: NewSeries)(not necessarily final name)addSeriesMountPoint(series_oc_id: string, realm_path: string)removeSeriesMountPoint(realm_path: string)(maybe also pass series id to check stuff?)
The admin UI is then changed to send a GraphQL request with multiple mutations in them. GraphQL guarantees us, that these are executed in order. And Tobira uses one DB transaction per GraphQL request, so the whole operation is atomic. Nice!
We do need to keep the old mountSeries endpoint around for some while, until the last admin UI using it is not supported anymore, but that's not a big problem.
Note though that the individual endpoints (especially the MountPoint ones) are still... no atomic perfectly defined operation. It still represents a "high level task" (like the current mountSeries) instead of manipulating Tobira's DB objects directly.
This comment was marked as resolved.
This comment was marked as resolved.
owi92
force-pushed
the
mount-and-move-series
branch
from
adc795b to
3f63c30
Compare
github-actions
bot
removed
the
status:conflicts
github-actions
bot
temporarily deployed
to
test-deployment-pr1225
owi92
force-pushed
the
mount-and-move-series
branch
from
3f63c30 to
4f86349
Compare
github-actions
bot
temporarily deployed
to
test-deployment-pr1225
LukasKalbertodt
requested changes
Oct 1, 2024
LukasKalbertodt
force-pushed
the
master
branch
from
df91940 to
ac46ed4
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
4f86349 to
6529c59
Compare
This comment has been minimized.
This comment has been minimized.
owi92
force-pushed
the
mount-and-move-series
branch
from
6529c59 to
bee6021
Compare
This comment has been minimized.
This comment has been minimized.
owi92
force-pushed
the
mount-and-move-series
branch
from
bee6021 to
482c721
Compare
owi92
force-pushed
the
mount-and-move-series
branch
from
482c721 to
bd9b1b3
Compare
LukasKalbertodt
requested changes
Oct 8, 2024
|
Oh and: once the admin UI PRs are merged, we should adjust our github action script ( |
owi92
force-pushed
the
mount-and-move-series
branch
from
bd9b1b3 to
274a1f0
Compare
This is necessary for an upcoming admin UI feature which will allow admins to change the path of series pages with no other blocks.
owi92
force-pushed
the
mount-and-move-series
branch
from
274a1f0 to
1bf3720
Compare
KatrinIhler
added a commit
to opencast/opencast
that referenced
this pull request
Oct 29, 2024
This adds - a) an endpoint to get paths of pages in Tobira that host an event - b) an endpoint to update the path of a series in Tobira This shouldn't break any existing behaviour. These are needed for additional requirements of opencast/opencast-admin-interface#311. Corresponding Tobira and admin-UI PRs: elan-ev/tobira#1225, opencast/opencast-admin-interface#878. ### Your pull request should… * [ ] have a concise title * [ ] [close an accompanying issue](https://docs.opencast.org/develop/developer/#participate/development-process/#automatically-closing-issues-when-a-pr-is-merged) if one exists * [ ] [be against the correct branch](https://docs.opencast.org/develop/developer/development-process#acceptance-criteria-for-patches-in-different-versions) * [ ] include migration scripts and documentation, if appropriate * [ ] pass automated tests * [ ] have a clean commit history * [ ] [have proper commit messages (title and body) for all commits](https://medium.com/@steveamaza/e028865e5791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for an upcoming admin UI feature which will allow admins to change the path of series pages with no other blocks (part of opencast/opencast-admin-interface#311).
This shouldn't break any existing behaviour.
Related Opencast and admin UI PRs: opencast/opencast#6091, opencast/opencast-admin-interface#878.