-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double precision #895
Merged
Merged
Double precision #895
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8a7ca7f
added configuration summary
pca006132 a5de6a5
use custom math type
pca006132 bee9570
use std function if possible
pca006132 38077f0
build success
pca006132 1511564
fix js binding
pca006132 39bcd2a
Merge remote-tracking branch 'upstream/master' into double-precision
pca006132 4014641
format
pca006132 6083019
use better primitives
pca006132 4d48102
use old precision for polygon tests
pca006132 36f9ef9
merging master
elalish 35967ea
merging master, cleanup hull
elalish 85c1bf7
fix polygon CCW check
elalish aab9606
temp-fix tests
elalish 0939e30
add simpler failing test case
elalish f014e1d
refactored CutKeyhole
elalish 900bd85
fixed tests
elalish fb4a81f
more keyholing fixes
elalish 25aabc3
truncate long debug output
elalish fbec45c
shrink SDF blobs test
elalish 2bf9405
fixed WASM and disabled zebra
elalish cf26a37
merging master
elalish dc6de0f
fix hull
elalish e0c8048
cleanup a bit
pca006132 9301363
merging master
elalish db46659
Merge branch 'double-precision' of github.com:pca006132/manifold into…
elalish 460a267
fix wasm
elalish d18d71d
CI cleanuo
elalish 536cfea
reenable zebra
elalish 9dcf037
upped precision and fixed tests
elalish 3ffc865
fix format
elalish d2b55ba
merging master
elalish 6fbd851
disable zebra test on windows
elalish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to just ignore these tests like this, but I'm hoping to at least verify these are the only tests making windows inexplicably die.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pca006132 it looks like this is indeed going to get our CI to finally pass. I'm considering just merging this PR while we work out what the Windows problem is. Mostly because I'd like to be able to keep working on PRs without creating an obscene number of merge conflicts. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, since you're probably asleep, I've open #910 to track and I'm merging this. Thanks - I'm really glad to finally be on double precision!