Supporting Kops v1.10 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mrmm . Thanks a lot for taking care of this 🙌 !! I'll test your PR during the weekend and release a |
|
@elafarge thanks for checking this. |
|
@elafarge Could you review this PR please. Cheers |
|
Hey @elafarge is there any news on this review ? |
|
Hi @mrmm . Sorry for the delay. |
|
Hey @elafarge, I have going through the changelog for any updates or feature added to the YAML Cluster definition and IG definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will include necessary changes support Kops v1.10.
List of the included changes and Ref. (this list will be updated throughout the commits) :
admissionControlhas been replaced byenableAdmissionControlanddisableAdmissionControl(mutually exclusive, order no longer matters) (Ref. Add --enable-admission-plugins API server flag for k8s 1.10 kubernetes/kops#5221)requireKubeconfigremoved in v1.10 (Ref. Validate that require-kubeconfig is not passed after 1.10 kubernetes/kops#5621)address(for specifiyinh inscecure address) replaced withinsecureBindAddress(Ref. Replace deprecated flags: address -> insecure-bind-address kubernetes/kops#5234)