Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js 14 #199

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Support Node.js 14 #199

merged 5 commits into from
Oct 20, 2020

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Jul 13, 2020

An additional fix to #195 allows it to compile in Node.js14.
Better than #195 because I'm using 'Nan::To'.

This was referenced Jul 13, 2020
@terion-name
Copy link

Why this not still merged? It works and is needed

@TimWolla
Copy link
Collaborator

I remember having received push privileges back when the Open Open Source concept was introduced for this repository. I am no longer using this. The software I used this in was replaced by a reimplementation in Rust. Thus I don't have a need for this and I am unable to actually test this. For some reason I am still watching this repository, though. As this got my attention I will try to help out anyway.

I am seeing that Travis is green and I eyeballed the diff. It's not looking incorrect to me. So I'll just go ahead and merge this. I am unable to publish to npm, though. But my understanding is that the version there is completely out of date anyway.

Thanks.

@TimWolla TimWolla merged commit 06f1633 into elad:master Oct 20, 2020
@TimWolla
Copy link
Collaborator

I remember having received push privileges back when the Open Open Source concept was introduced for this repository.

Found the old discussion about this: #102 (comment)

@TimWolla
Copy link
Collaborator

It appears that Travis is dog slow lately. The builds for master are still queued. I'm happy to merge GitHub Actions based CI if you ping me.

@abetomo abetomo deleted the support_nodejs14 branch October 20, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants