Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to python 3.13 #403

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Update CI to python 3.13 #403

merged 1 commit into from
Dec 23, 2024

Conversation

elParaguayo
Copy link
Owner

No description provided.

@elParaguayo elParaguayo force-pushed the ci-py313 branch 4 times, most recently from 037cade to 168f5f0 Compare December 22, 2024 21:58
@elParaguayo
Copy link
Owner Author

@sde1000 - sorry to ping you directly on this but you commented on the same issue in the qtile repo.

I'm hitting the same error message

               gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -fPIC -I/home/runner/work/qtile-extras/qtile-extras/.tox/py313/include -I/opt/hostedtoolcache/Python/3.13.1/x64/include/python3.13 -c build/temp.linux-x86_64-cpython-313/xkbcommon._ffi.c -o build/temp.linux-x86_64-cpython-313/build/temp.linux-x86_64-cpython-313/xkbcommon._ffi.o
              build/temp.linux-x86_64-cpython-313/xkbcommon._ffi.c: In function ‘_cffi_const_XKB_CONTEXT_NO_SECURE_GETENV’:
              build/temp.linux-x86_64-cpython-313/xkbcommon._ffi.c:1021:12: error: ‘XKB_CONTEXT_NO_SECURE_GETENV’ undeclared (first use in this function); did you mean ‘_cffi_const_XKB_CONTEXT_NO_SECURE_GETENV’?
               1021 |   int n = (XKB_CONTEXT_NO_SECURE_GETENV) <= 0;
                    |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    |            _cffi_const_XKB_CONTEXT_NO_SECURE_GETENV
              build/temp.linux-x86_64-cpython-313/xkbcommon._ffi.c:1021:12: note: each undeclared identifier is reported only once for each function it appears in
              error: command '/usr/bin/gcc' failed with exit code 1

and have pinned xkbcommon < 1.1 in my tox.ini file. However, this error seems to happen when another dependency is being installed (pywlroots) but that's happened after we've installed xkbcommon < 1.1.

Any ideas how I can fix this?

@sde1000
Copy link

sde1000 commented Dec 22, 2024

It looks like pip install pywlroots==0.17.0 is pulling in xkbcommon-1.5.1 which then fails to build against libxkbcommon-1.4

pywlroots depends on "xkbcommon>=0.2", which would be satisfied by xkbcommon-1.0, so I'm not sure why pip is deciding to pull in the later version.

Why does pywlroots==0.17.0 get its own "pip install" command, rather than just being included in the list of dependencies?

EDIT 2: Looks like using --no-build-isolation for pywlroots fixes the problem. Feels like it shouldn't be necessary...

@elParaguayo elParaguayo force-pushed the ci-py313 branch 3 times, most recently from bc56bb5 to 60b9fda Compare December 23, 2024 07:51
@elParaguayo
Copy link
Owner Author

elParaguayo commented Dec 23, 2024

Why does pywlroots==0.17.0 get its own "pip install" command, rather than just being included in the list of dependencies?

Because it must be installed after pywayland. Including it in the list of dependencies doesn't guarantee the correct installation order will be followed. (EDIT: tried it - still failed - same issue).

What I don't understand is why the main qtile repo doesn't have the same issue that I'm experiencing here.

@elParaguayo elParaguayo force-pushed the ci-py313 branch 2 times, most recently from 44708e0 to b7ab1f8 Compare December 23, 2024 08:15
@elParaguayo elParaguayo merged commit 08a9de2 into main Dec 23, 2024
14 of 15 checks passed
@elParaguayo elParaguayo deleted the ci-py313 branch December 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants