src: Increase num_render_targets to 32 for Chromium #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I meant to get to this earlier. Is 32 really required? Does any number >16 and <32 work? I'm just slightly concerned that NVDEC will allocate all those frames up front, and 32 is going to start taking a lot of memory, esp. at 4k resolutions. |
|
The maximum surface index I saw in logs was 24, but I only ever tested a single YouTube video playing for no more than 5 minutes at a time and this number seemed to have a tendency to increase a bit while the video was playing, so I decided 32 would be a safer bet. |
|
Ok, I'll merge this in as-is but we may have to revisit it at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, nvEndpicture fails in cv->cuvidDecodePicture(nvCtx->decoder, picParams) when Chromium's VaapiVideoDecoder is used.