Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md, remind about ffmpeg #212

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

lucasmr
Copy link
Contributor

@lucasmr lucasmr commented Jun 4, 2023

Relevant for Gentoo builds, it needs USE=vaapi or Firefox won't try using vaapi.

@elFarto
Copy link
Owner

elFarto commented Jun 5, 2023

Hmm, you don't need ffmpeg to compile this library so putting those instructions there is not correct. It would probably be better as a separate sub-section in the Firefox section.

Relevant for Gentoo builds, it needs USE=vaapi or Firefox won't try using vaapi.
@elFarto
Copy link
Owner

elFarto commented Jun 5, 2023

Ok, that's better. Thanks for the patch.

@elFarto elFarto merged commit 8b61d59 into elFarto:master Jun 5, 2023
@nbryant42
Copy link

nbryant42 commented Jun 7, 2023

Only relevant for those building FF from source... official builds have a libmozavcodec.so etc.

For example, on Ubuntu 22.04, the default ffmpeg is compiled without any acceleration, but FF works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants