meson: properly check for libva, add libdrm dependency #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the code a little cleaner Signed-off-by: Emil Velikov <[email protected]>
Aka we need libva for the backend headers, but we don't link against it. Thus we only need a partial_dependency(compile: true) Signed-off-by: Emil Velikov <[email protected]>
The pkg-config --cflags (pulled by the meson dependency()) already provides the correct directory. Drop the inline libdrm vs drm magic. Just like libva - this is a partial (compile-only) dependency. Signed-off-by: Emil Velikov <[email protected]>
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings everyone,
Here we group the dependencies, annotate libva as partial (compile-only) dependency + add the missing libdrm (again partial compile-only) dependency to the list.
First commit is cosmetic, while the latter two remove over-linking and misc include hacks.