Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Make gst-codecparser optional #100

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

philipl
Copy link
Contributor

@philipl philipl commented Jul 18, 2022

Disable vp8 and vp9 if not available.

I'm not sure how truly useful this is, but gstreamer has a huge pile of dependencies, and maybe one might not want to install all of them just to get access to the codecparser if vp8 and vp9 aren't essential for you.

@elFarto
Copy link
Owner

elFarto commented Jul 18, 2022

Thanks for the PR. A couple of things:

  • VP8 doesn't use gst-codecparsers any more, so it doesn't need to be disabled.
  • I don't think we need the #ifdefs to remove the checks, as there's already code below that to filter the list of hardware supported codecs with whatever ones we have compiled support for.

As the gstreamer packages have very extensive dependencies, you might
not want to install all of them if you don't specifically need vp9
support in the driver.
@philipl
Copy link
Contributor Author

philipl commented Jul 19, 2022

Thanks for the review. I've updated accordingly.

@elFarto
Copy link
Owner

elFarto commented Jul 19, 2022

Looks good!

@elFarto elFarto merged commit 8e66a2f into elFarto:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants