Adds unit tests #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies build.js to emit to a gen folder so tests, dist, and gen code can be separated.
* updates packaging and tests to pass. updates to jsx-runtime over jsx classis * update peer dependency range since jsx-runtime updates started shipping in preact 10.5.0
|
I'm trying to find a way to cherry pick the testing stuff from this but it's all mixed together with other reworks. I solved the issue we discussed with your inspiration but there are some other changes here I don't totally agree with, but the testing would be useful |
ekwoka
force-pushed
the
master
branch
3 times, most recently
from
607a064 to
0ba9178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests.
gen, which is nice for separating generated code, tests, and dist.To see the tests fail,
git checkout 8308710e6786b92883423ce7f71c6f7987a55e29. This is the commit where the tests are setup, but the fixes are not in place.To see the tests pass, checkout the tip of this branch.