Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dependent goformation module to a local fork #8081

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cheeseandcereal
Copy link
Contributor

Description

This PR migrates away from using the goformation fork at https://github.com/weaveworks/goformation/tree/master.next to a 'local' fork within this repo under the goformation/ subdirectory.

The fork at weaveworks/goformation is really only used for this project, so maintaining a separate repo for a separate fork which requires manual updates adds complexity to the update process when releasing new features. Given that the upstream repository awslabs/goformation is archived, we are on our own for the maintenance of this fork, and shouldn't encourage its use elsewhere anyways.

Longer term, we may want to investigate alternatives to this dependent module/package, but for now, this just moves the dependency into the same repository here so we can more easily update it.

This PR also updates some of the golangci-lint config since it was using deprecated options; we are excluding goformation from being linted with the rest of the project.

I was able to build/run the tests/confirm everything is still working.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added kind/improvement skip-release-notes Causes PR not to show in release notes area/tech-debt Leftover improvements in code, testing and building labels Dec 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello cheeseandcereal 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call, thanks Adam!

@cheeseandcereal cheeseandcereal merged commit 84ac23d into eksctl-io:main Dec 11, 2024
12 of 13 checks passed
@cheeseandcereal cheeseandcereal deleted the vendor-goformation branch December 11, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt Leftover improvements in code, testing and building kind/improvement skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants