Migrate dependent goformation module to a local fork #8081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates away from using the goformation fork at https://github.com/weaveworks/goformation/tree/master.next to a 'local' fork within this repo under the
goformation/
subdirectory.The fork at
weaveworks/goformation
is really only used for this project, so maintaining a separate repo for a separate fork which requires manual updates adds complexity to the update process when releasing new features. Given that the upstream repositoryawslabs/goformation
is archived, we are on our own for the maintenance of this fork, and shouldn't encourage its use elsewhere anyways.Longer term, we may want to investigate alternatives to this dependent module/package, but for now, this just moves the dependency into the same repository here so we can more easily update it.
This PR also updates some of the golangci-lint config since it was using deprecated options; we are excluding goformation from being linted with the rest of the project.
I was able to build/run the tests/confirm everything is still working.
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯