Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed iam permissions bug for karpenter #7778

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

siennathesane
Copy link
Contributor

Description

Adds proper IAM permissions to the Karpenter CFN provider.

fixes #7454

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Sorry, something went wrong.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello siennathesane 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@siennathesane
Copy link
Contributor Author

Poke...

1 similar comment
@siennathesane
Copy link
Contributor Author

Poke...

@a-hilaly
Copy link
Member

cc @TiberiuGC @cPu1

@siennathesane
Copy link
Contributor Author

siennathesane commented Jun 24, 2024

Poke...

1 similar comment
@siennathesane
Copy link
Contributor Author

Poke...

@cPu1
Copy link
Contributor

cPu1 commented Jul 2, 2024

Poke...

@siennathesane apologies for the delay. We are currently occupied with other priorities, but we'll aim to get this merged this week.

Signed-off-by: Sienna Satterwhite <[email protected]>
@cPu1 cPu1 merged commit 8ab26a7 into eksctl-io:main Jul 4, 2024
9 checks passed
@siennathesane siennathesane deleted the bug/7454 branch July 5, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Karpenter v0.32.4 does not work when deployed via eksctl
3 participants