Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable IMDSv1 in unowned integration tests #7722

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Disable IMDSv1 in unowned integration tests #7722

merged 1 commit into from
Apr 24, 2024

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Apr 24, 2024 •
edited
Loading

Description

Disables usage of IMDSv1 in unowned integration tests. This is likely the only place where IMDSv1 was still being used in eksctl.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added kind/improvement area/tech-debt Leftover improvements in code, testing and building labels Apr 24, 2024
@cPu1 cPu1 force-pushed the disable-imds-v1 branch from d383ea3 to 1bf1b3e Compare April 24, 2024 11:07
@cPu1 cPu1 force-pushed the disable-imds-v1 branch from 1bf1b3e to 5a63580 Compare April 24, 2024 14:38
@cPu1 cPu1 merged commit d35fa56 into eksctl-io:main Apr 24, 2024
9 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cPu1 @TiberiuGC