Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopters for eksctl #7027

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Adopters for eksctl #7027

merged 2 commits into from
Aug 30, 2023

Conversation

Himangini
Copy link
Collaborator

@Himangini Himangini commented Aug 29, 2023 •
edited
Loading

Description

Added functionality to show eksctl adopters on eksctl.io
Closes https://github.com/eksctl-io/eksctl-private/issues/1158

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini added kind/feature New feature or request area/docs labels Aug 29, 2023
@Himangini Himangini requested review from cPu1 and TiberiuGC August 29, 2023 14:14
TiberiuGC
TiberiuGC approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@TiberiuGC TiberiuGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Himangini Himangini enabled auto-merge August 30, 2023 08:53
@Himangini Himangini merged commit 0c2ced9 into eksctl-io:main Aug 30, 2023
@Himangini Himangini deleted the eksctl-adopters branch August 30, 2023 10:29
@Himangini Himangini added kind/docs User documentation and removed area/docs labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Himangini @cPu1 @TiberiuGC