Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/hpc7g node arm support #6743

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Add/hpc7g node arm support #6743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45f89f6
add support for hpc7g arm images
vsoch Jun 26, 2023
9141821
update efa-device-plugin.yaml to one that workkks
vsoch Jun 26, 2023
f95076b
add additional hpc7g instance types
vsoch Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/addons/assets/efa-device-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: "beta.kubernetes.io/instance-type"
- key: "node.kubernetes.io/instance-type"
operator: In
values:
- c5n.18xlarge
Expand All @@ -62,6 +62,9 @@ spec:
- g6.24xlarge
- g6.48xlarge
- hpc6a.48xlarge
- hpc7g.16xlarge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V - lets update with all hpc7g types here since they all have EFA. Add hpc7g.8xlarge, hpc7g.4xlarge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do! I didn’t want to add them before being able to test. Any updates on if it might be possible to have an ARM build for the plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! And per our discussion, I can offer to do a PR to add these images here https://github.com/aws-samples/efa-device-plugin-helm/blob/main/aws-efa-k8s-device-plugin after we finish up here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay opened, albeit we should not merge it! aws-samples/efa-device-plugin-helm#1

- hpc7g.8xlarge
- hpc7g.4xlarge
- i3en.12xlarge
- i3en.24xlarge
- i3en.metal
Expand Down Expand Up @@ -124,6 +127,9 @@ spec:
- g6.24xlarge
- g6.48xlarge
- hpc6a.48xlarge
- hpc7g.16xlarge
- hpc7g.8xlarge
- hpc7g.4xlarge
- i3en.12xlarge
- i3en.24xlarge
- i3en.metal
Expand Down Expand Up @@ -175,3 +181,4 @@ spec:
- name: device-plugin
hostPath:
path: /var/lib/kubelet/device-plugins

1 change: 1 addition & 0 deletions pkg/utils/instance/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func IsARMInstanceType(instanceType string) bool {
strings.HasPrefix(instanceType, "im4g") ||
strings.HasPrefix(instanceType, "is4g") ||
strings.HasPrefix(instanceType, "g5g") ||
strings.HasPrefix(instanceType, "hpc7g") ||
strings.HasPrefix(instanceType, "x2g")
}

Expand Down