Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m7g and r7g as ARM instance types #6436

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

TiberiuGC
Copy link
Contributor

@TiberiuGC TiberiuGC commented Mar 15, 2023

Description

Closes #6377

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini
Copy link
Contributor

@TiberiuGC this is still in draft 😅
do we need to add tests for these new instance types?

@TiberiuGC
Copy link
Contributor Author

TiberiuGC commented Mar 16, 2023

@TiberiuGC this is still in draft 😅 do we need to add tests for these new instance types?

Yeah I forgot that if you open a draft PR once it defaults to draft for subsequent PRs 😓
Hmm, I don't see any of the IsXXXXInstanceType() functions having any tests. They are quite basic tho 🤔 Do you have any suggestions for where tests would be worth it?

@TiberiuGC TiberiuGC marked this pull request as ready for review March 16, 2023 13:41
@Himangini
Copy link
Contributor

@TiberiuGC this is still in draft 😅 do we need to add tests for these new instance types?

Yeah I forgot that if you open a draft PR once it defaults to draft for subsequent PRs 😓 Hmm, I don't see any of the IsXXXXInstanceType() functions having any tests. They are quite basic tho 🤔 Do you have any suggestions for where tests would be worth it?

Nah, it's fine. 👍🏻

@TiberiuGC TiberiuGC enabled auto-merge (squash) March 17, 2023 06:41
@TiberiuGC TiberiuGC merged commit a6767ed into eksctl-io:main Mar 17, 2023
@yuxiang-zhang yuxiang-zhang mentioned this pull request Jan 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] m7g and r7g are not handled by IsARMInstanceType
3 participants