Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on how pod disruption budget policies influence cluster deletion #6209

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add note on how pod disruption budget policies influence cluster deletion #6209

merged 1 commit into from
Jan 30, 2023

Conversation

TiberiuGC
Copy link
Contributor

Description

Closes #5855

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added kind/docs User documentation area/docs labels Jan 30, 2023
@TiberiuGC TiberiuGC mentioned this pull request Jan 30, 2023
Closed
@TiberiuGC TiberiuGC requested review from cPu1 and Himangini January 30, 2023 12:11
Himangini
Himangini approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiberiuGC TiberiuGC merged commit 8d66c1a into eksctl-io:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Cluster delete hangs with aws-ebs-csi-driver addon (unable to drain node)
3 participants
@TiberiuGC @cPu1 @Himangini