Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping things #5561

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Housekeeping things #5561

merged 1 commit into from
Aug 1, 2022

Conversation

Himangini
Copy link
Collaborator

Description

Removed typos from code and updated the core maintainer list

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini added the skip-release-notes Causes PR not to show in release notes label Aug 1, 2022
@Himangini Himangini merged commit 9dae0a0 into eksctl-io:main Aug 1, 2022
@Himangini Himangini deleted the update-typos branch August 1, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Himangini @cPu1 @nikimanoledaki