Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selecting subnet IDs from subnet names #5261

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix selecting subnet IDs from subnet names #5261

merged 1 commit into from
May 16, 2022

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented May 16, 2022 •
edited
Loading

Description

Fixes selecting subnet IDs from subnet names specified in the VPC config.

Fixes #5260

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/bug label May 16, 2022
Skarlso
Skarlso approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@cPu1 cPu1 mentioned this pull request May 16, 2022
Closed
@cPu1 cPu1 force-pushed the subnet-name-mapping branch from 1ea37f1 to 48cbb96 Compare May 16, 2022 12:55
Himangini
Himangini approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@cPu1 cPu1 merged commit 1a4e3ac into eksctl-io:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does this not recognize subnet name in v0.97.0 version?
3 participants
@cPu1 @Skarlso @Himangini