Use EKS APIs default vpc-cni addon version for ipv6 clusters #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
commented
Apr 6, 2022
Comment on lines
-73
to
+79
| Name: api.VPCCNIAddon, | ||
| Version: "latest", | ||
| Name: api.VPCCNIAddon, | ||
| }, | ||
| { | ||
| Name: api.KubeProxyAddon, | ||
| Version: "latest", | ||
| Name: api.KubeProxyAddon, | ||
| }, | ||
| { | ||
| Name: api.CoreDNSAddon, | ||
| Version: "latest", | ||
| Name: api.CoreDNSAddon, |
There was a problem hiding this comment.
we should always check the default version works, encase we have to enforce any versions again in the future
Skarlso
reviewed
Apr 6, 2022
| @@ -270,7 +270,6 @@ func (c *ClusterConfig) unsupportedVPCCNIAddonVersion() (bool, error) { | |||
| for _, addon := range c.Addons { | |||
| if addon.Name == VPCCNIAddon { | |||
| if addon.Version == "" { | |||
| addon.Version = minimumVPCCNIVersionForIPv6 | |||
There was a problem hiding this comment.
so.... if it's empty we leave it empty?
There was a problem hiding this comment.
yep. Empty value means the EKS API uses the default value. E.g.:
eksctl utils describe-addon-versions --name vpc-cni --kubernetes-version 1.22
2022-04-06 15:22:57 [ℹ] eksctl version 0.88.0
2022-04-06 15:22:57 [ℹ] using region us-west-2
2022-04-06 15:22:57 [ℹ] describing addon versions for addon: vpc-cni
{
Addons: [{
AddonName: "vpc-cni",
AddonVersions: [
{
AddonVersion: "v1.10.2-eksbuild.1",
Architecture: ["amd64","arm64"],
Compatibilities: [{
ClusterVersion: "1.22",
DefaultVersion: false,
PlatformVersions: ["*"]
}]
},
{
AddonVersion: "v1.10.1-eksbuild.1",
Architecture: ["amd64","arm64"],
Compatibilities: [{
ClusterVersion: "1.22",
DefaultVersion: true,
PlatformVersions: ["*"]
}]
},
{
AddonVersion: "v1.9.3-eksbuild.1",
Architecture: ["amd64","arm64"],
Compatibilities: [{
ClusterVersion: "1.22",
DefaultVersion: false,
PlatformVersions: ["*"]
}]
},
{
v1.10.1-eksbuild.1 would be used
Skarlso
approved these changes
Apr 7, 2022
nikimanoledaki
approved these changes
Apr 7, 2022
SlevinWasAlreadyTaken
pushed a commit
to SlevinWasAlreadyTaken/eksctl
that referenced
this pull request
Apr 11, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5074
We used to set the version of the
vpc-cniif no version was set when creating ipv6 clusters. c095e3b this was because the default version available by EKS wasn't supporting ipv6, so we had to mandate a minimum version. Now this minimum version isn't available on the EKS api for1.22, so we shouldn't default to it, but we should still check the user provided version is greater than it.green run https://github.com/weaveworks/eksctl-ci/actions/runs/2103683555