Fix usage of pre-existing VPCs via config file

[errordeveloper]

Description

• closes cannot create cluster on existing VPC with config file #436

Checklist

• Code compiles correctly (i.e make build)
• All tests passing (i.e. make test)
• Added/modified documentation as required (such as the README)

[errordeveloper]

We should make this lowercase, but that would a bigger change and we'd have to bump the API version. Next time!

[errordeveloper]

Integration test looking pass.

[dlespiau]

\o/

[pputnik]

I still have the issue, the vpc and subnets already created. The code:

---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: eksworkshop-eksctl
  region: eu-west-1

vpc:
  id: vpc-0da60ff028192627e
  subnets:
    Public: 
      eu-west-1b: { id: subnet-08dbc4f966c6410d4 }
      eu-west-1a: { id: subnet-0e0d14242f3472e8e }
      eu-west-1c: { id: subnet-02408be52718f5398 }
    Private: 
      eu-west-1a: { id: subnet-00b9ec0511703c9f6 }

managedNodeGroups:
- name: nodegroup
  instanceType: t3a.mini
  desiredCapacity: 2
  iam:
    withAddonPolicies:
      albIngress: true

The error is in CF template ("Subnet Id is required"):

  ControlPlane:
    Type: 'AWS::EKS::Cluster'
    Properties:
      Name: eksworkshop-eksctl
      ResourcesVpcConfig:
        SecurityGroupIds:
          - !Ref ControlPlaneSecurityGroup
        SubnetIds:
          - ''
          - ''
          - ''
          - ''
          - ''
          - ''
      RoleArn: !GetAtt 
        - ServiceRole
        - Arn
      Version: '1.15'

Am I doing something wrong? I want my nodes be in public subnet.

[martina-if]

Hi @pputnik ,

I think there might be a mistake in the cluster configuration you are using:

vpc:
  subnets:
    Public: 
      eu-west-1b: { id: subnet-08dbc4f966c6410d4 }
      eu-west-1a: { id: subnet-0e0d14242f3472e8e }
      eu-west-1c: { id: subnet-02408be52718f5398 }
    Private: 
      eu-west-1a: { id: subnet-00b9ec0511703c9f6 }

Public and Private should be all lowercase:

vpc:
  subnets:
    public: 
      eu-west-1b: { id: subnet-08dbc4f966c6410d4 }
      eu-west-1a: { id: subnet-0e0d14242f3472e8e }
      eu-west-1c: { id: subnet-02408be52718f5398 }
    private: 
      eu-west-1a: { id: subnet-00b9ec0511703c9f6 }

Let us know if that doesn't help!

[pputnik]

Hi @martina-if , thank you, I took uppercase version it from solution in one of the linked issues.