Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: associate additional security groups on node creation #412

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Jan 9, 2019

Adds the --node-security-groups flag, along with the corresponding config key securityGroups, that accepts ARNs of the additional security groups attached to the nodes.

The additional security groups can be used for allowing extra egress from/ingress to pods running on the nodes.

Resolves #397

Adds the `--node-security-groups` flag, along with the corresponding config key `securityGroups`, that accepts ARNs of the additional security groups attached to the nodes.

The additional security groups can be used for allowing extra egress from/ingress to pods running on the nodes.

Resolves eksctl-io#397
@mumoshu
Copy link
Contributor Author

mumoshu commented Jan 10, 2019

I've created a brand new cluster with eksctl built from the branch running eksctl create cluster --node-security-groups SG_ID. All the EC2 instances in the node group has the security group attached, and the stack template includes the specified security group ID in it:

{"AssociatePublicIpAddress":true,"IamInstanceProfile":{"Ref":"NodeInstanceProfile"},"ImageId":"ami-094fa4044a2a3cf52","InstanceType":"m5.large","SecurityGroups":[{"Ref":"SG"},"sg-0f4e477e7e496aa26"], ...

@mumoshu mumoshu changed the title WIP: feat: associate additional security groups on node creation feat: associate additional security groups on node creation Jan 10, 2019
@errordeveloper
Copy link
Contributor

This is great, thanks for adding it! However, I think this is an advanced use-case and I'd rather avoid adding any new flags beyond what we have already and only enable this via config file. But at the moment, there is no --config-file in eksctl create nodegroup, and we need to work on the API and define standalone NodeGroup object, so not very trivial.

@whereisaaron
Copy link

I was looking for this option, and it is already done, which is great, but it is not currently documented in the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants