Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove supported MNG flags from deny-list #3887

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Remove supported MNG flags from deny-list #3887

merged 1 commit into from
Jun 23, 2021

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Jun 23, 2021 •
edited
Loading

Description

instance-name and instance-prefix are both supported for managed nodegroups.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1
Remove supported MNG flags from deny-list
2ae811e 
instance-name and instance-prefix are both supported for managed nodegroups
@cPu1 cPu1 merged commit be06b5c into eksctl-io:main Jun 23, 2021
@cPu1 cPu1 deleted the mng-compatible-flags branch June 23, 2021 11:28
@Callisto13 Callisto13 mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
area/general-cli area/managed-nodegroup EKS Managed Nodegroups kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cPu1 @Callisto13