Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service principal for cluster and Fargate profile role #3473

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Fix service principal for cluster and Fargate profile role #3473

merged 2 commits into from
Mar 25, 2021

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Mar 24, 2021 •
edited
Loading

Description

Fixes #3472

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 force-pushed the fix-service-principal branch from e0cf9f4 to 3b3065e Compare March 25, 2021 12:13
@cPu1 cPu1 enabled auto-merge March 25, 2021 12:14
@cPu1 cPu1 merged commit 7207a54 into eksctl-io:main Mar 25, 2021
@cPu1 cPu1 deleted the fix-service-principal branch March 25, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
area/aws-iam kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use correct Service Principal for IAM roles created for cluster & fargate pods
3 participants
@cPu1 @Callisto13 @aclevername