eksctl info command

[neha-viswanathan]

Closes #3029

Description

This MR contains an implementation of the eksctl info command

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the userdocs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes
• (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[neha-viswanathan]

@aclevername 👋🏽 this is a rough first attempt of the eksctl info command. Please review and let me know your suggestions.

[aclevername]

Thanks @neha-viswanathan ! Looks good, could we do some error handling? For example if we fail to discover the kubectl client we should just present unknown or something like that 😄

[neha-viswanathan]

@aclevername ready for review!

[neha-viswanathan]

@Callisto13 Hi! I'll need your guidance here - I don't understand why the make lint is failing? Please help!

[Callisto13]

No problem 😃 .

So the linter is reporting this error:

errors in package: [/__w/eksctl/eksctl/cmd/eksctl/main.go:45:49: undeclared name: infoCmd]"

Because the infoCmd function you are referencing on line 45 of cmd/eksctl/main.go does not exist. (This line here: cmdutils.AddResourceCmd(flagGrouping, rootCmd, infoCmd).) You need to create that infoCmd function, which should call your new GetVersion function.

You can use the line below in cmd/eksctl/main.go which wires up the versionCmd as a guide. versionCmd is defined in cmd/eksctl/version.go, so following that pattern you can create a new cmd/eksctl/info.go which will define infoCmd and call your GetVersion function.

Hope this helps, let me know if you have any more questions or if anything is unclear 👍

[neha-viswanathan]

@Callisto13 for some reason that file did not get committed earlier. 😕 Thanks for pointing it out. 😃

[Callisto13]

for some reason that file did not get committed earlier

Gah! that's annoying 😅

[Callisto13]

Is is possible to have some tests for this file please?

[Callisto13]

Hey @neha-viswanathan! Just checking in on the status of this, do you plan to finish or would you like it taken over? Thanks!

[neha-viswanathan]

Hey @neha-viswanathan! Just checking in on the status of this, do you plan to finish or would you like it taken over? Thanks!

Hi @Callisto13 I'll try and wrap this up within the next week or so. I will keep you posted in any case.

[Callisto13]

Awesome 🎉

[Callisto13]

let's print something here when the marshal fails, just so users don't get confused about why the command returned nothing:

Suggested change

	func String() string {
	if data, err := json.Marshal(GetInfo()); err == nil {
	return string(data)
	}
	return ""
	}
	func String() string {
	data, err := json.Marshal(GetInfo())
	if err != nil {
	return fmt.Sprintf("failed to marshal info into json: %q", err)
	}
	return string(data)
	}

[Callisto13]

oooh i didn't know BeElementOf was a thing! nice!

[Callisto13]

LGTM 🚀 thanks for working on this!