Add support for Asia Pacific (Osaka) region #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to DoCreateFargateProfiles so that this is checked as part of cluster create and fargateprofile create
aclevername
reviewed
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3031.
The
ap-northeast-3region is not opt-in, so it can use the standard account ID, which means adding support for it is very simple (a little too simple, let me know if there is more to it 😅 ).Fargate support in this region will lag behind for a couple of days, so there is now a check on create to log this. I have also added a warning in the docs, but since this will be removed in like a week, I wonder if it is necessary? Maybe simply pinning an issue in this repo will be enough to cover us for that time 🤷♀️ .
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯