Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log suggestion to delete IRSA when create stack fails #3332

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

aclevername
Copy link
Contributor

Description

#2901

Deleting an IRSA when the stack failed does succeed, so having a friendly hint to remind you is useful

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Co-authored-by: Chetan Patwal <[email protected]>
@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Feb 23, 2021
@aclevername aclevername linked an issue Feb 23, 2021 that may be closed by this pull request
@aclevername aclevername enabled auto-merge (squash) February 23, 2021 10:55
@aclevername aclevername merged commit b6e122b into eksctl-io:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create iamserviceaccount does not clean up on failure
2 participants