Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github action workflow #3094

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Update github action workflow #3094

merged 4 commits into from
Jan 18, 2021

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Jan 18, 2021 •
edited
Loading

Description

  • Set the stale github acitons worflow to start scanning from June 1st 2018 (first issue was created after this)
  • Add exempt labels

https://github.com/actions/stale

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Jan 18, 2021
@michaelbeaumont
Copy link
Contributor

Can we skip marking issues of a certain priority stale?

@aclevername
Copy link
Contributor Author

aclevername commented Jan 18, 2021 •
edited
Loading

@michaelbeaumont yes, we can add exempt-issue-labels: 'awaiting-approval,work-in-progress'

I've added exempt-issue-labels: 'priority/critical,priority/important-longterm,priority/important-soon,priority/weave'

@aclevername aclevername changed the title Set start date for stale issue github action workflow Update github action workflow Jan 18, 2021
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Jan 18, 2021 •
edited
Loading

@aclevername Maybe also good first issue? WDYT

@aclevername
Copy link
Contributor Author

@aclevername Maybe also good first issue? WDYT

👍 I like, I'll add.

@Callisto13
Copy link
Contributor

i also want to create a label for permanent notices (like #2963 ) which i dont want closed. hang on while i think of a name

@aclevername aclevername force-pushed the stale-gh-workflow-start-date branch from beb2aaf to ca84d4b Compare January 18, 2021 15:39
@weaveworksbot weaveworksbot merged commit 7cde120 into master Jan 18, 2021
@weaveworksbot weaveworksbot deleted the stale-gh-workflow-start-date branch January 18, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Callisto13 Callisto13 Awaiting requested review from Callisto13

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclevername @michaelbeaumont @Callisto13 @weaveworksbot