Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gp3 as the default VolumeType #3078

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Set gp3 as the default VolumeType #3078

merged 2 commits into from
Jan 18, 2021

Conversation

Callisto13
Copy link
Contributor

Closes #2891.

Description

  • Set gp3 as the default volumeType
  • Provide default settings for IOPS and Throughput for gp3 type
  • Provide default setting for IOPS io1 type
  • Ensure given IOPS and Throughput values are within accepted ranges

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Callisto13 Callisto13 requested a review from a team January 15, 2021 16:25
aclevername
aclevername approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Callisto13 Callisto13 force-pushed the cb-gp3 branch 2 times, most recently from a9350e8 to 0b434e7 Compare January 18, 2021 09:31
@aclevername aclevername mentioned this pull request Jan 18, 2021
Closed
@Callisto13 Callisto13 force-pushed the cb-gp3 branch 3 times, most recently from 051604a to 611dff6 Compare January 18, 2021 16:59
@Callisto13
Set gp3 as the default VolumeType
bcbf0ae 
Also:
- Provide default settings for IOPS and Throughput for gp3 type
- Provide default setting for IOPS io1 type
- Ensure given IOPS and Throughput values are within accepted ranges
@weaveworksbot weaveworksbot merged commit 71e49b5 into eksctl-io:master Jan 18, 2021
@Callisto13
Copy link
Contributor Author

woah who merged this? it was not done

@michaelbeaumont
Copy link
Contributor

I merged it, you can see I added the autosquash label.

@Callisto13
Copy link
Contributor Author

👍 yep i saw once i had woken up a bit. I'll open a new PR to handle the rest

@michaelbeaumont
Copy link
Contributor

Sorry, it seemed rather complete. What's missing?

@Callisto13
Copy link
Contributor Author

Callisto13 commented Jan 19, 2021 •
edited
Loading

When manual testing I realised it was not 100% working for managed ngs

@Callisto13 Callisto13 deleted the cb-gp3 branch January 19, 2021 12:14
@Callisto13 Callisto13 mentioned this pull request Jan 19, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@aclevername aclevername Awaiting requested review from aclevername

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for EBS gp3 volume type/ storage class
4 participants
@Callisto13 @michaelbeaumont @aclevername @weaveworksbot