-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write Contributing docs #3022
Re-write Contributing docs #3022
Conversation
1e8a030
to
e484ce7
Compare
6584c98
to
6a89e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 1 minor nitpick 😄
|
||
*Note:* This is still somewhat [TBD](https://github.com/weaveworks/eksctl/issues/215). | ||
# Proposals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get a markdown template for proposals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 👍 . I can submit that in a separate PR to give people more space to consider the format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a good refresh and I like the upbeat and welcoming tone. Thank you for taking the time to go through this and expand on detail in relevant places which helps us and them.
I've left minor comments, no blockers from me 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also: - Update issue/pr templates - New Community and Maintainer pages
6a89e5b
to
0b044f1
Compare
There is quite a lot here. I suggest you don't read the raw markdown, but the nicely rendered stuff instead (I have linked them).
This is part of the general community strategy, which I will share later.
It would be great if we could get this PR signed off by EOD 08.01.20, ty!
Description
There is now also a MAINTAINER.md which is for our benefit. I know we have the handbook googledoc, but that is... not great. It is still necessary to have a private place for docs which are secret, I wonder if a repo is a better tool for that?Edit: after some discussion this is going to live somewhere else and I will ask for review on that later: Re-write Contributing docs #3022 (comment)Please let me know if there is anything you would like to remove or if there is anything I have missed which we should add. This PR is a big part of the community strategy which I will share soon.
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)What was I listening to when I wrote this? A lot of Long Distance Calling.