Node private networking #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 26, 2018
errordeveloper
force-pushed
the
node-private-networking
branch
from
83afbe2 to
27aa8f4
Compare
|
This is terrific! I look forward to trying it out. |
errordeveloper
force-pushed
the
node-private-networking
branch
from
27aa8f4 to
249228c
Compare
|
It's ready for someone to review, but I'd like to make sure it does what's intended (in theory it should, but I might have missed something). |
errordeveloper
force-pushed
the
node-private-networking
branch
6 times, most recently
from
b0cc9e2 to
8db1275
Compare
- add docs - include NAT Gateway - ensure control plane also connects to private subnets - ensure `kubernetes.io/role/internal-elb=1` tag is set properly - ensure SSH port is only accessible inside the VPC - use boolean ng.PrivateNetworking field and helper method to get string instead of string ng.SubnetTopology field
errordeveloper
force-pushed
the
node-private-networking
branch
from
8db1275 to
9544a48
Compare
errordeveloper
force-pushed
the
node-private-networking
branch
from
95e83a0 to
d852d5f
Compare
|
Thanks @stefanprodan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
--node-private-networkingflag, which will make initial nodegroup use private subnet.Checklist
make build)make test)