Support more than 4 azs #2804
Merged
Support more than 4 azs #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
approved these changes
Nov 10, 2020
| return subnets, nil | ||
| } | ||
|
|
||
| func SplitInto8(parent *net.IPNet) ([]*net.IPNet, error) { |
There was a problem hiding this comment.
Sorry forgot to include comment, these 2 functions could be reduced into SplitIntoN
There was a problem hiding this comment.
@michaelbeaumont I'm a bit hesitant to do that, while I managed to manipulate the first function to accurately produce splits of 16 instead of 8, I don't know how to ensure the same change for any given input, e.g. splitting into 10.
There was a problem hiding this comment.
Yes, it should work for any power of two (and only for powers of two).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently EKSCTL limits you to specify 4 AZs, if you attempt to specify more it fails as we only split up the VPC CIDR block into 8 chunks (4x 1 private & 1 public subnet). This PR ups the capacity to 8 AZs (currently the biggest region has only 6 AZs) by adding the option to split the VPC CIDR block into 16.
related issue: #1359
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)