Add Integration Tests For Scaling #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests for the recent scaling command. Issue #267
richardcase
reviewed
Oct 17, 2018
integration/creategetdelete_test.go
Outdated
| Fail(fmt.Sprintf("error starting process: %v", err), 1) | ||
| } | ||
|
|
||
| cmdSession.Wait(deleteTimeout) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
integration/integration_test.go
Outdated
| @@ -17,6 +17,7 @@ const ( | |||
| createTimeout = 25 * time.Minute | |||
| deleteTimeout = 15 * time.Minute | |||
| getTimeout = 1 * time.Minute | |||
| scaleTimeout = 1 * time.Minute | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
errordeveloper
approved these changes
Oct 17, 2018
|
I'll merge, so you don't need to rebase and seek approval again. The Github's rebase+merge or the 'Update branch' buttons are kind of odd choices, but maybe we should discuss this sometime on Slack... So far the preferred way for active contributors is LGTM+self-merge. |
|
Great to get this in.....thanks @Lazyshot 🏆 |
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Update log verbosity and log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the recent scaling command.
Issue #267
Checklist
make build)make test)