Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Add instance lifecycle labels to env #2623

Closed
wants to merge 2 commits into from
Closed

Fix - Add instance lifecycle labels to env #2623

wants to merge 2 commits into from

Conversation

vaibhav-random
Copy link
Contributor

Description

Checklist

  • [+] Added tests that cover your change (if possible)
  • [+] Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • [+] Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@vaibhav-random vaibhav-random mentioned this pull request Sep 7, 2020
Merged
2 tasks
@martina-if martina-if added kind/bug skip-release-notes Causes PR not to show in release notes labels Sep 8, 2020
@martina-if
Copy link
Contributor

Hi @vaibhav-random, thank you for the fix. Can you please run make generate-all, commit the changes, and run the manual testing end to end?

@martina-if
Copy link
Contributor

closed in favor of #2624

@martina-if martina-if closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaibhav-random @martina-if