Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EKS 1.13 as deprecated #2259

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented May 28, 2020

Description

Fixes #2141

Created as draft PR, so that there will be no notification. Will send to review closing to 30th June.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras changed the title Deprecate 1.13 Mark EKS 1.13 as deprecated May 28, 2020
@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from 59f2d56 to 7e48750 Compare May 28, 2020 14:05
@martina-if
Copy link
Contributor

Merge before Friday 26th so it's released with 0.23.0

@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from d824071 to af38955 Compare June 15, 2020 09:56
@sayboras
Copy link
Contributor Author

Merge before Friday 26th so it's released with 0.23.0

Thanks, let me set reminder for myself in slack 👍

@martina-if
Copy link
Contributor

@sayboras I think we can already merge this since 0.22.0 was already branched out. Can you please rebase it? :)

@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from 332f753 to 6a94304 Compare June 17, 2020 08:40
@sayboras sayboras marked this pull request as ready for review June 17, 2020 08:40
@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from 6a94304 to 5315a70 Compare June 17, 2020 09:12
@sayboras
Copy link
Contributor Author

I think we can already merge this since 0.22.0 was already branched out. Can you please rebase it? :)

@martina-if Done 💯

@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from 5315a70 to 2eba2f6 Compare June 17, 2020 10:01
@sayboras sayboras force-pushed the feature/deprecate-1-13 branch from 8715a76 to 012fdd4 Compare June 18, 2020 12:42
@martina-if
Copy link
Contributor

Manually tested and it works well 👍

./eksctl create cluster -f examples/01-simple-cluster.yaml 
[ℹ]  eksctl version 0.23.0-dev+8715a769.2020-06-18T14:57:51Z
[ℹ]  using region eu-north-1
Error: invalid version, 1.13 is no longer supported, supported values: 1.14, 1.15, 1.16
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
./eksctl create cluster --name martina-test-1-13-3 --version 1.13
[ℹ]  eksctl version 0.23.0-dev+8715a769.2020-06-18T14:57:51Z
[ℹ]  using region eu-north-1
Error: invalid version, 1.13 is no longer supported, supported values: 1.14, 1.15, 1.16
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

@martina-if martina-if merged commit f503573 into eksctl-io:master Jun 18, 2020
@sayboras sayboras deleted the feature/deprecate-1-13 branch June 18, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark End of Support for kube 1.13
2 participants