Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name argument for delete iamserviceaccount #2165

Merged
merged 1 commit into from
May 14, 2020
Merged

Add name argument for delete iamserviceaccount #2165

merged 1 commit into from
May 14, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented May 11, 2020 •
edited
Loading

Description

To add name argument for delete iamserviceaccount CLI. This is also to
make the behavior consistent with create iamserviceaccount CLI.

While working on this, I also correct error message related to name args

Closes #2087

Testing

Before 
$ ./eksctl delete iamserviceaccount --cluster dummy dummysa                                         
Error: --name must be set
After 
$ ./eksctl delete iamserviceaccount --cluster dummy dummysa
[ℹ]  eksctl version 0.20.0-dev+f63eea27.2020-05-11T21:45:32Z
[ℹ]  using region ap-southeast-2
Error: checking AWS STS access – cannot get role ARN for current session: ExpiredToken: The security token included in the request is expired
	status code: 403, request id: 7be241f2-640a-4050-a48b-a86f5092ba9a

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras force-pushed the feature/delete-iam-name-args branch from f63eea2 to fea96cf Compare May 11, 2020 13:43
@martina-if martina-if changed the title feat(cli): Add name argument for delete iamserviceaccount Add name argument for delete iamserviceaccount May 12, 2020
@sayboras sayboras force-pushed the feature/delete-iam-name-args branch from fea96cf to 91d2989 Compare May 13, 2020 10:52
@sayboras
feat(cli): Add name argument for delete iamserviceaccount
5324fae 
To add name argument for delete iamserviceaccount CLI. This is also to
make the behavior consistent with create iamserviceaccount CLI.

While working on this, I also correct error message related to name args

Closes eksctl-io#2087
@sayboras sayboras force-pushed the feature/delete-iam-name-args branch from 91d2989 to 5324fae Compare May 14, 2020 11:00
michaelbeaumont
michaelbeaumont approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sayboras

@michaelbeaumont michaelbeaumont merged commit 6b8fe63 into eksctl-io:master May 14, 2020
@sayboras sayboras deleted the feature/delete-iam-name-args branch May 14, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
area/general-cli kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support name argument for delete iamserviceaccount.
3 participants
@sayboras @michaelbeaumont @martina-if