Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install neuron plugin for inf1 instances #2162

Merged
merged 12 commits into from
May 20, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 11, 2020

Description

Checklist

  • Added tests that cover your change (if possible)
  • Add integration test
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont force-pushed the mb/inf1_plugin branch 2 times, most recently from 095f6e8 to 3ec3f82 Compare May 11, 2020 14:53
@michaelbeaumont michaelbeaumont marked this pull request as ready for review May 11, 2020 14:53
@michaelbeaumont michaelbeaumont force-pushed the mb/inf1_plugin branch 2 times, most recently from 203092c to cc6fe64 Compare May 11, 2020 15:08
@michaelbeaumont michaelbeaumont changed the base branch from master to release-0.20 May 19, 2020 16:06
@michaelbeaumont
Copy link
Contributor Author

@martina-if @cPu1 integration tests pass.

@michaelbeaumont michaelbeaumont merged commit 57a797d into eksctl-io:release-0.20 May 20, 2020
@deliahu
Copy link

deliahu commented Sep 9, 2020

@michaelbeaumont is there a way to prevent the device plugin from being installed via the eksctl config file, or is eksctl create cluster --install-neuron-plugin=false the only way? It's not a big deal, I just have a slight preference for the config file since all my other configuration is there, so I wanted to check if it was possible.

@michaelbeaumont michaelbeaumont deleted the mb/inf1_plugin branch September 9, 2020 16:02
@michaelbeaumont
Copy link
Contributor Author

@deliahu Hi, no there isn't at the moment.

@deliahu
Copy link

deliahu commented Sep 9, 2020

@michaelbeaumont ok sounds good, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants