Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate secretsEncryption.keyARN for nil #2110

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Validate secretsEncryption.keyARN for nil #2110

merged 2 commits into from
Apr 29, 2020

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Apr 29, 2020

Description

Fixes a panic by validating secretsEncryption.keyARN for nil-ness.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@cPu1 cPu1 added the kind/bug label Apr 29, 2020
@cPu1 cPu1 force-pushed the fix-kms-validation branch 4 times, most recently from 647e972 to c88d9f5 Compare April 29, 2020 12:37
@cPu1 cPu1 force-pushed the fix-kms-validation branch 3 times, most recently from 30fe15b to dbfed40 Compare April 29, 2020 12:58
@cPu1 cPu1 force-pushed the fix-kms-validation branch from dbfed40 to 3510b81 Compare April 29, 2020 12:59
@cPu1 cPu1 merged commit 3c050cf into master Apr 29, 2020
@cPu1 cPu1 deleted the fix-kms-validation branch April 29, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants