Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tagging iamserviceaccount. #1756

Merged
merged 3 commits into from
May 1, 2020
Merged

Add support for tagging iamserviceaccount. #1756

merged 3 commits into from
May 1, 2020

Conversation

PyScott
Copy link
Contributor

@PyScott PyScott commented Jan 24, 2020 •
edited by rndstr
Loading

Description

Allow tagging iamserviceaccount CloudFormation stack and IAM role through config file and CLI arguments.

Added Tags field to ClusterIAMServiceAccount that is consumed by createIAMServiceAccountTask.

resolves #1561

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup) and target version (e.g. version/0.12.0)
  • Make sure the title of the PR is a good description that can go into the release notes

@PyScott PyScott mentioned this pull request Jan 24, 2020
Closed
5 tasks
@PyScott PyScott requested a review from cPu1 January 29, 2020 17:38
@rndstr rndstr requested review from rndstr and removed request for cPu1 April 29, 2020 16:51
@rndstr
Copy link
Contributor

rndstr commented Apr 30, 2020 •
edited
Loading

i can confirm a manual test was successful (for create cluster -f and create iamserviceaccount). I've also been looking at adding a test and might be able to get it running soon.

rndstr
rndstr approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @PyScott

@cPu1 cPu1 merged commit d9a423c into eksctl-io:master May 1, 2020
@martina-if martina-if added kind/feature New feature or request priority/weave labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndstr rndstr rndstr approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tagging support in create iamserviceaccount
4 participants
@PyScott @rndstr @martina-if @cPu1